Issue #2971 Add display names to tests #3057
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| public class RelationshipComputerTest { | ||
|
|
||
| @Test | ||
| @DisplayName("empty lists") |
There was a problem hiding this comment.
In this exercise, the order of the tests doesn’t align perfectly with the canonical data file, especially towards the end. Could you also fix the order of the tests to match the canonical data file? Also, I believe there are no extra or missing tests, but let me know if you find any
| @DisplayName("substrings from the beginning") | ||
| public void substringsFromTheBeginning() { | ||
| expectedWordCount.put("joe", 1); | ||
| expectedWordCount.put("can't", 1); | ||
| expectedWordCount.put("tell", 1); | ||
| expectedWordCount.put("between", 1); | ||
| expectedWordCount.put("app", 1); | ||
| expectedWordCount.put("apple", 1); | ||
| expectedWordCount.put("and", 1); | ||
| expectedWordCount.put("a", 1); | ||
|
|
||
| actualWordCount = wordCount.phrase("Joe can't tell between app, apple and a."); | ||
| assertThat(actualWordCount).isEqualTo(expectedWordCount); | ||
| } | ||
|
|
||
| @Disabled("Remove to run test") | ||
| @Test | ||
| @DisplayName("with quotations") |
There was a problem hiding this comment.
Also, the order of these two is reversed; fix this one
2 participants
pull request
Description
Added DisplayName annotations to test methods based on the canonical data
Changes made
Added DisplayName annotation to the following exercises:
Verification
All tests have passed using ./gradlew test
Style has been checked using ./gradlew check
Compiled successfully using ./gradlew compileStarterTestJava
Related Issue
Addresses issue #2971
Reviewer Resources:
Track Policies